Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3831

build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Flags:
      Patch

      Description

      Specifically, we get a bunch of errors like:

      test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

      gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing

      I've only seen this in gcc-6, but the faq seems to indicate it could occur in gcc-5 as well.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                codyps Cody Schafer
                Reporter:
                codyps Cody Schafer
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: