[THRIFT-3828] cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Fix Version/s: 0.10.0
• Component/s: Build Process
• Patch Info: Patch Available
• Flags: Patch
• Assignee: James E. King III
• Reporter: Cody Schafer
• Created: 16/May/16 21:17
• Updated: 05/Apr/17 15:37
• Resolved: 17/Nov/16 21:47

Description

This is due to the current quoting of those variables when passed to `include_directories()`. These variables may (and soon will, see below) be empty in the case where the include directory is a system include path that is implicitly included.

I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't work with includes that are part of the platform/system include path (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types of directories to Boost_INCLUDE_DIRS.

Issue Links

• links to: GitHub Pull Request #1082