Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3828

cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Build Process
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Flags:
      Patch

      Description

      This is due to the current quoting of those variables when passed to `include_directories()`. These variables may (and soon will, see below) be empty in the case where the include directory is a system include path that is implicitly included.

      I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't work with includes that are part of the platform/system include path (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types of directories to Boost_INCLUDE_DIRS.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                codyps Cody Schafer
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: