[THRIFT-3769] Fix logic of THRIFT-2268

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.12.0
• Component/s: Java - Library
• Patch Info: Patch Available
• Flags: Patch
• Assignee: James E. King III
• Reporter: Harsh J
• Created: 01/Apr/16 07:05
• Updated: 20/Sep/19 06:50
• Resolved: 01/May/18 12:17

Description

THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled servers, but the commit doesn't help in doing so (its just adding more specific noise today).

This is because the transport factory overrides disallow throwing specific execution types (no TTransportException in signature), and thereby all implementations will throw a RuntimeException-wrapped exception, which the added catch clauses would never encounter.

https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219
https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295

We'll need to unwrap the RuntimeException to perform an actual valid cause check.

Issue Links

• causes: THRIFT-4858 Java TThreadPoolServer: confusing error message on closed socket
• is related to: THRIFT-4805 Suppress excessive logging of SASL TTransportExceptions in case of END_OF_FILE
• is related to: HIVE-18964 HiveServer2 should not log errors when clients issue connection reset
• is related to: THRIFT-2268 Modify TSaslTransport to ignore TCP health checks from loadbalancers
• links to: GitHub Pull Request #1543