Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3769

Fix logic of THRIFT-2268

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9.2
    • 0.12.0
    • Java - Library
    • None
    • Patch Available
    • Patch

    Description

      THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled servers, but the commit doesn't help in doing so (its just adding more specific noise today).

      This is because the transport factory overrides disallow throwing specific execution types (no TTransportException in signature), and thereby all implementations will throw a RuntimeException-wrapped exception, which the added catch clauses would never encounter.

      https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219
      https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295

      We'll need to unwrap the RuntimeException to perform an actual valid cause check.

      Attachments

        1. THRIFT-3769.patch
          2 kB
          Harsh J

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4858 Java TThreadPoolServer: confusing error message on closed socket

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4805 Suppress excessive logging of SASL TTransportExceptions in case of END_OF_FILE

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HIVE-18964 HiveServer2 should not log errors when clients issue connection reset

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-2268 Modify TSaslTransport to ignore TCP health checks from loadbalancers

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link GitHub Pull Request #1543

          Activity

            People

              jking3 James E. King III
              qwertymaniac Harsh J
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: