Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3769

Fix logic of THRIFT-2268

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.12.0
    • Component/s: Java - Library
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Flags:
      Patch

      Description

      THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled servers, but the commit doesn't help in doing so (its just adding more specific noise today).

      This is because the transport factory overrides disallow throwing specific execution types (no TTransportException in signature), and thereby all implementations will throw a RuntimeException-wrapped exception, which the added catch clauses would never encounter.

      https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219
      https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295

      We'll need to unwrap the RuntimeException to perform an actual valid cause check.

        Attachments

        1. THRIFT-3769.patch
          2 kB
          Harsh J

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                qwertymaniac Harsh J
              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: