Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3613 Port Python C extension to Python 3
  3. THRIFT-3699

Fix integer limit symbol includes in Python C extension

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.10.0
    • 0.10.0
    • Python - Library
    • None

    Description

      INT32_MAX etc was not included correctly
      Newer GCC and Clang are permissive enough to accept them but it didn't work on our CentOS 6 image.
      Rather than doing C-compatibility includes correctly, I replaced them with std::numeric_limits.

      The patch also adds workaround for VC++ where std::numeric_limits does not work in a single particular place of code for some reason.

      Attachments

        Activity

          People

            nsuke Nobuaki Sukegawa
            nsuke Nobuaki Sukegawa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: