[THRIFT-3629] Parser sets exitcode on errors, but generator does not

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Compiler (General)
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 13/Feb/16 22:23
• Updated: 19/Feb/16 02:17
• Resolved: 14/Feb/16 12:51

Description

In main.cc, the parse() function and the generate() function do behave inconsistently w/regard to exceptions being thrown.

Both functions catch the exception, but ...

• parse() exits with code 1 and prints the error to stderr
• generate() only prints the error to stdout and finally exits with code 0

Proposal is to change generate() similar to the behaviour of parse(). Patch is ready, follows.