[THRIFT-3610] Streamline exception handling in Python server handler

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Component/s: Python - Compiler
• Assignee: Nobuaki Sukegawa
• Reporter: Nobuaki Sukegawa
• Created: 10/Feb/16 21:58
• Updated: 14/Dec/17 13:54
• Resolved: 30/Nov/17 17:38

Description

It also serves as a reference implementation of THRIFT-3607.
Only needed behavior change was to send catched TApplicationException, rather than opaque TApplicationException(INTERNAL_ERROR).

It now looks like this (comments are not generated)

try:
    # handler call
    ...
except TTransport.TTransportException:  # disconnect
    raise
except Xception as err1:  # declared exception
    msg_type = TMessageType.REPLY
    result.err1 = err1
except TApplicationException as ex:    # send as is
    logging.exception('TApplication exception in handler')
    msg_type = TMessageType.EXCEPTION
    result = ex
except Exception:  # send INTERNAL_ERROR
    logging.exception('Unexpected exception in handler')
    msg_type = TMessageType.EXCEPTION
    result = TApplicationException(...)
result.write(...)

Issue Links

• links to: GitHub Pull Request #842
• links to: GitHub Pull Request #1426