[THRIFT-3609] Remove or replace TestPortFixture.h - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.10.0
Component/s: C++ - Library, Test Suite
Labels:
None

Description

Today 6 cpp lib tests use TestPortFixture.h. ~~THRIFT-3608~~ experimented with correcting one of these cases in lib/cpp/test/SecurityTest.cpp, but a general cleanup should remove all uses of static ports in the cpp tests to improve robustness and open the path to parallel testing - at least in the cpp libs.

Attachments

Issue Links

relates to

THRIFT-3608 lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

Closed

Sub-Tasks

1.	Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports	Closed	John Sirois
2.	Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports	Closed	John Sirois
3.	Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports	Closed	John Sirois
4.	Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.	Closed	John Sirois
5.	Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.	Closed	John Sirois
6.	Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports	Closed	John Sirois

Activity

People

Assignee:: John Sirois

Reporter:: John Sirois

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 10/Feb/16 17:29

Updated:: 19/Feb/16 02:17

Resolved:: 17/Feb/16 15:01