[THRIFT-3595] Perl Bindings: Set serialization/deserialization differs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Affects Version/s: 0.9.1, 0.9.2, 0.9.3
• Component/s: Perl - Compiler
• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: Adam Millerchip
• Created: 02/Feb/16 08:19
• Updated: 06/Apr/18 13:10
• Resolved: 06/Apr/18 13:10

Description

In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the serialization code expects an arrayref. This causes the code to die when called if attempting to serialize a previously dezerialized Set.

Additionally, it looks like there is a typo in the test that is testing this feature:

https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262

If you change that @$setout to @$setin, the test fails.

It doesn't make much sense to implement a Set in Perl as array, because arrays allow duplicate entries and are ordered.

I've written a change for the serialization that correctly expects a hashref: https://github.com/apache/thrift/pull/831

Issue Links

• is superceded by: THRIFT-3190 In perl, a thrift set<> type should use a more proper native implementation
• links to: GitHub Pull Request #831
• links to: GitHub Pull Request #831