Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-358

Change how external thrift files' generated code is required

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.1
    • Ruby - Compiler
    • None
    • Patch Available

    Description

      Currently, Ruby generated structs assume that any external Thrift files' generated code can be found in exactly the same directory, which is often not the case. This leads to issues when you have a bunch of different thrift files and generated code living in different places.

      The best solution seems to be to change the generator to omit the path leading up to the included thrift file's name, and just assuming that the developer will put the external generated code into the Ruby load path.

      Attachments

        1. thrift-358.patch
          0.6 kB
          Bryan Duxbury

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bryanduxbury Bryan Duxbury
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment