Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3566

C++/Qt: TQTcpServerTest::test_communicate() is never executed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.3, 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None

      Description

      The unit test is broken/never executed because of the following three reasons:
      1. TQTcpServerTest::test_communicate() needs to be declared as Qt slot, otherwise the QTest-framework would never execute it. This explains why the unit test always succeeded
      2. The server and synchronous client cannot be executed in the same thread, as the server requires the mainloop to run
      3. The expected response from the server is "foo, bar" and not "foo, foo".

        Attachments

          Activity

            People

            • Assignee:
              sebastian.zenker Sebastian Zenker
              Reporter:
              sebastian.zenker Sebastian Zenker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: