[THRIFT-3547] NodeJS generated require() paths should mirror include paths

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.9.3
• Component/s: Node.js - Compiler
• Assignee: Unassigned
• Reporter: Yunchi Luo
• Created: 13/Jan/16 05:09
• Updated: 21/Jun/18 17:26

Description

NodeJS uses file paths rather than namespaces to manage modules. However, the Thrift generated code ignores file paths.

I.e. if we have

foo.thrift:
include "../../shared.thrift";

It will turn into

foo_types.js:
var shared_types = require("./shared.thrift");

This forces us to put all generated node code in the same directory. It's problematic since if we happen to have

a/foo.thrift
b/foo.thrift

One file will have to overwrite the other...

I'm happy to make a patch for this, but unclear to me how much of a breaking change this would be for people, if it is at all.

Issue Links

• is related to: THRIFT-1684 javascript generated services files should use the js namespace in the file name
• links to: GitHub Pull Request #791