Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
0.9.3
-
windows
visual studio
Description
1. Thrift.cpp should be removed from the libthrift.vcxproj file, this is not used anymore, causes compile time error.
2. Missing TProtocol.cpp and TOutput.cpp from libthrift.vcxproj results in linker errors.
0.9.2 was ok, none of these problems were found there
GitHub user kcris opened a pull request:
https://github.com/apache/thrift/pull/745
[fix] libthrift.vcxproj was not compilable with Visual Studio
libthrift.vcxproj did not properly include TOutput.cpp and TProtocol.cpp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kcris/thrift fix]-compile-issue-with-MSVC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #745
commit 5ff420b3cb55deecd5b2e1b47c37322c82802024
Author: KCris <cristian.kovari@gmail.com>
Date: 2015-12-16T15:02:56Z
[fix] libthrift.vcxproj was not compilable with Visual Studio
—
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
—
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-