[THRIFT-3484] Consolidate temporary buffers in Java's TCompactProtocol

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Java - Library
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Tom Lee
• Reporter: Tom Lee
• Created: 10/Dec/15 08:23
• Updated: 02/Feb/16 17:41
• Resolved: 02/Feb/16 17:41

Description

TCompactProtocol allocates a number of small temporary buffers per-instance and, in some cases e.g. readDouble(), per-method-call. It's fairly trivial to consolidate these & save maybe 32 bytes of overhead per TCompactProtocol instance and possibly a bunch more for structs that contain lots of doubles.

Seems like we can also avoid allocating empty ByteBuffers + byte[]s in readBinary() by returning singletons.