[THRIFT-3456] rounding issue in static assert

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: D - Compiler
• Assignee: Tolstokulakov Nikolay
• Reporter: Tolstokulakov Nikolay
• Created: 30/Nov/15 05:38
• Updated: 18/Mar/16 17:54
• Resolved: 18/Mar/16 17:54

Description

thrift.codegen.idlgen

static assert(structIdlString!WithDefaults ==
`struct WithDefaults {
-1: string a = "asdf",
-2: double b = 3.1415,
1: WithoutMeta c =

{a: "foo", b: 3, }

,
}
`);

This assert fails for me, because struct contains double b = 3.1414999...999
I suggest replace 3.1415 with 1.0e+20
This value is free from rounding issues.

FYI
thrift.internal.ctfe contains similar unit test, but it is not use strict match:
static assert(ctfeToString(3.1415).startsWith("3.141"));

Create pull request: https://github.com/apache/thrift/pull/720