[THRIFT-3431] Avoid "schemes" HashMap lookups during struct reads/writes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: Java - Compiler
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Tom Lee
• Reporter: Tom Lee
• Created: 19/Nov/15 10:36
• Updated: 02/Feb/16 17:46
• Resolved: 02/Feb/16 17:46

Description

Generated Java code for structs doesn't need to do a HashMap lookup on every read/write operation.

Was surprised to see this show up in profilers under certain high throughput, write-heavy loads. Unclear if the cost was in the hashCode() implementation of the key or in the map lookup itself, but given this map never changes, for now it seems like it can be pretty safely replaced with a simple (and, in most cases, predictable) branch.