-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 0.10.0
-
Component/s: Node.js - Library
-
Labels:None
-
Patch Info:Patch Available
There's at least 3 problems in NodeJS binary field.
- API are inconsistent across binary/comact/JSON protocols
- compact/JSON wire format is imcompatible with other languages
(JSON :THRIFT-3200) - size of compact wire format is 2x of the original binary
I propose following changes to fix this
- Change JSON protocol return value from string to Buffer (same as binary/compact)
- Change JSON protocol wire format to Base64 (same as other languages)
- Change compact protocol wire format to plain binary (same as other languages)
- is duplicated by
-
THRIFT-3925 Client service recieves string instead of buffer when using TCompactProtocol with node.js library.
-
- Closed
-
- is related to
-
THRIFT-3925 Client service recieves string instead of buffer when using TCompactProtocol with node.js library.
-
- Closed
-