[THRIFT-3409] NodeJS binary field issues

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Node.js - Library
• Patch Info: Patch Available
• Assignee: Nobuaki Sukegawa
• Reporter: Nobuaki Sukegawa
• Created: 03/Nov/15 16:08
• Updated: 18/Dec/18 16:43
• Resolved: 18/Mar/16 17:54

Description

There's at least 3 problems in NodeJS binary field.

1. API are inconsistent across binary/comact/JSON protocols
2. compact/JSON wire format is imcompatible with other languages
   (JSON : THRIFT-3200)
3. size of compact wire format is 2x of the original binary

I propose following changes to fix this

1. Change JSON protocol return value from string to Buffer (same as binary/compact)
2. Change JSON protocol wire format to Base64 (same as other languages)
3. Change compact protocol wire format to plain binary (same as other languages)

Issue Links

• is duplicated by: THRIFT-3925 Client service recieves string instead of buffer when using TCompactProtocol with node.js library.
• is related to: THRIFT-3925 Client service recieves string instead of buffer when using TCompactProtocol with node.js library.