Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3298

thrift endian converters may conflict with other libraries

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.3
    • C++ - Library
    • None
    • Patch Available

    Description

      Thrift C++ library offers some endian converters in TProtocol.h, e.g. ntohll, htonll, and etc. Some other libraries may also have these kinds of converters, such as ZooKeeper. And if we include TProtocol.h prior to zookeeper.h, zookeeper's htonll will be replaced by the thrift macros mentioned above. Consequently, I propose that we may add prefix "THRIFT_" to all these converters.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            in-chief Xiaoshuang LU
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment