Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3298

thrift endian converters may conflict with other libraries

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.9.3
    • Component/s: C++ - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Thrift C++ library offers some endian converters in TProtocol.h, e.g. ntohll, htonll, and etc. Some other libraries may also have these kinds of converters, such as ZooKeeper. And if we include TProtocol.h prior to zookeeper.h, zookeeper's htonll will be replaced by the thrift macros mentioned above. Consequently, I propose that we may add prefix "THRIFT_" to all these converters.

        Attachments

        1. THRIFT-3298.patch
          5 kB
          Xiaoshuang LU

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              in-chief Xiaoshuang LU
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: