[THRIFT-3191] Perl compiler does not add support for unexpected exception handling

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Perl - Compiler
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 16/Jun/15 20:20
• Updated: 25/Aug/15 04:44
• Resolved: 30/Jul/15 13:10

Description

While adding "make cross" test server support for some other refactoring I found that the generated code to handle testException exception responses does not work properly. The test says that the code can die with the specified exceptions, but it can also die with Thrift::TException.

The generated code that fails in ThriftTest.pm:

sub process_testException {
    my ($self, $seqid, $input, $output) = @_;
    my $args = new ThriftTest::ThriftTest_testException_args();
    $args->read($input);
    $input->readMessageEnd();
    my $result = new ThriftTest::ThriftTest_testException_result();
    eval {
      $self->{handler}->testException($args->arg);
    }; if( UNIVERSAL::isa($@,'ThriftTest::Xception') ){ 
      $result->{err1} = $@;
    }
    $output->writeMessageBegin('testException', TMessageType::REPLY, $seqid);
    $result->write($output);
    $output->writeMessageEnd();
    $output->getTransport()->flush();
}

If the resulting implementation dies with a new Thrift::TException("foo"), the C++ client side gets a void back.
The result should be a TMessageType::EXCEPTION so that the client understands something went wrong at a more fundamental level than in the handler.

There are a number of other issues with "make cross", for example TApplicationException's constructor in perl doesn't pass the arguments to the TException::SUPER::new method. All of these things need to be fixed in order for make cross to work.

Issue Links

• Is contained by: THRIFT-3053 Perl SSL Socket Support (Encryption)
• relates to: THRIFT-3189 Perl ServerSocket should allow a specific interface to be listened to