Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Labels:
      None

      Description

      The generated validate() methods don't call validate() on their child structs directly. Instead, they wait until the child structs' write() method is called. This could lead to structs being partially written to the wire before encountering an invalid substruct. Additionally, users calling validate() directly would not get the expected behavior.

      1. thrift-317.patch
        3 kB
        Bryan Duxbury

        Activity

        Bryan Duxbury created issue -
        Bryan Duxbury made changes -
        Field Original Value New Value
        Fix Version/s 0.2 [ 12313769 ]
        Todd Lipcon made changes -
        Fix Version/s 0.3 [ 12314451 ]
        Fix Version/s 0.2 [ 12313769 ]
        Bryan Duxbury made changes -
        Assignee Bryan Duxbury [ bryanduxbury ]
        Bryan Duxbury made changes -
        Fix Version/s 0.4 [ 12314960 ]
        Fix Version/s 0.3 [ 12314451 ]
        Bryan Duxbury made changes -
        Fix Version/s 0.4 [ 12314960 ]
        Bryan Duxbury made changes -
        Attachment thrift-317.patch [ 12507262 ]
        Bryan Duxbury made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 0.9 [ 12316294 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Bryan Duxbury
            Reporter:
            Bryan Duxbury
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development