[THRIFT-3168] Fix Maven POM

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Assignee: Jake Farrell
• Reporter: Maarten Billemont
• Created: 20/May/15 00:23
• Updated: 21/Jul/15 02:21
• Resolved: 23/Jun/15 12:40

Description

1. THRIFT-2269 was not fixed properly. Sources are supposed to be deployed using a "jar" type. maven-dependency-plugin cannot resolve them otherwise and IDEs such as IntelliJ IDEA are unable to resolve or even manually attach sources with a "src" extension/type.

2. Between 0.9.1 and 0.9.2, the POM for libthrift was modified to remove a dependency on commons-lang3. As a result, the code generated by libthrift no longer builds as it misses this dependency. The dependency needs to be restored, or whatever reason resulted in its removal re-evaluated to take this requirement into account. Personally, I'd prefer if we could just drop this dependency entirely and use native Java language utilities such as `Objects` to solve the problems `commons-lang3` is trying to solve.

Issue Links

• duplicates: THRIFT-2269 Can deploy libthrift-source.jar to maven center repository