[THRIFT-3149] Make ReadFieldN methods in generated Go code private

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Go - Compiler
• Assignee: Konstantin Shaposhnikov
• Reporter: Konstantin Shaposhnikov
• Created: 14/May/15 05:19
• Updated: 10/Nov/15 22:59
• Resolved: 15/May/15 20:38

Description

The go thrift compiler generates ReadFieldN and writeFieldN methods for every field of a struct. E.g.:

func (p *Statistics) ReadField1(iprot thrift.TProtocol) error {
...
}

func (p *Statistics) writeField1(oprot thrift.TProtocol) (err error) {
...
}

ReadField1, ReadField2, etc are not very descriptive names and shouldn't be part of public API of a generated package (like writeFieldN).

Issue Links

• breaks: THRIFT-3413 Thrift code generation bug in Go when extending service