Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3117

Java TSSLTransportFactory can't load certificates within JAR archive

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.9.2
    • 0.9.3
    • Java - Library
    • None

    Description

      TSSLTransportFactory's setKeyStore/setTrustStore accept only plain file system paths what makes it impossible to use URL's or classpath based resources. E.g., I didn't find a way to load certificate from JAR.

      I propose to look for both URLs and resources if the file can not be found by the given path. It's how it is done in ActiveMQ:

      https://access.redhat.com/documentation/en-US/Fuse_ESB/4.4.1/html/ActiveMQ_Security_Guide/files/SSL-SecureJavaClients.html

      https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/ActiveMQSslConnectionFactory.java#L175-L206

      Attachments

        Activity

          People

            Unassigned Unassigned
            smyatkin Smyatkin Maxim
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified