[THRIFT-3091] c_glib service method should return result from handler method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: C glib - Compiler
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Nobuaki Sukegawa
• Reporter: Nobuaki Sukegawa
• Created: 11/Apr/15 17:06
• Updated: 21/Jul/15 02:21
• Resolved: 12/Apr/15 09:43

Description

Generated c_glib service method has gboolean return type but actually returned nothing at all.

It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 treats it as if returning zero.

The patch adds missing "return " to implementation(handler) method call in the last line of service method.

Note that it also includes style fix (0 -> FALSE) in the same line which is not essential.