Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3091

c_glib service method should return result from handler method

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • C glib - Compiler
    • None
    • Patch Available
    • Patch

    Description

      Generated c_glib service method has gboolean return type but actually returned nothing at all.

      It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 treats it as if returning zero.

      The patch adds missing "return " to implementation(handler) method call in the last line of service method.

      Note that it also includes style fix (0 -> FALSE) in the same line which is not essential.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nsuke Nobuaki Sukegawa
            nsuke Nobuaki Sukegawa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment