Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3066

C++ TDenseProtocol assert modifies instead of checks

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.9.3
    • Component/s: C++ - Library
    • Labels:
      None

      Description

      cppcheck-1.68 found an assertion that is assigning a value:

        // If this is the end of the top-level write, we should have just popped
        // the TypeSpec passed to the constructor.
        if (ts_stack_.empty()) {
          assert(old_tts = type_spec_);
          return;
        }
      

        Attachments

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              jking3 James E. King III
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: