[THRIFT-3066] C++ TDenseProtocol assert modifies instead of checks

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 31/Mar/15 19:54
• Updated: 21/Jul/15 02:21
• Resolved: 04/May/15 13:36

Description

cppcheck-1.68 found an assertion that is assigning a value:

  // If this is the end of the top-level write, we should have just popped
  // the TypeSpec passed to the constructor.
  if (ts_stack_.empty()) {
    assert(old_tts = type_spec_);
    return;
  }