[THRIFT-2981] IDL with no namespace produces unparsable PHP

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: PHP - Compiler

Environment

all

• Assignee: Randy Abernethy
• Reporter: Randy Abernethy
• Created: 06/Feb/15 00:56
• Updated: 25/Aug/15 05:47
• Resolved: 25/Aug/15 05:10

Description

Compiling IDL for PHP without a namespace like:

service hi {
     void myFunc()
}

generates hi.php with this at the top:

namespace ; 

which causes PHP to produce:

PHP Parse error:  syntax error, unexpected ';', expecting identifier (T_STRING) or \\\\ (T_NS_SEPARATOR) or '{' in ... on line 2

The compiler is generating the namespace statement even when there isn't one, which blows up the PHP interpreter. Patch supresses service and type file output of namespace unless there actually is one.