[THRIFT-2934] createServer signature mismatch

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Node.js - Library, Tutorial
• Assignee: Randy Abernethy
• Reporter: Alan Cheung
• Created: 08/Jan/15 02:05
• Updated: 21/Jul/15 02:21
• Resolved: 02/Feb/15 13:21

Description

The nodejs example https://thrift.apache.org/tutorial/nodejs

If we createServer without a third option argument, would result in

if (options.tls) {
^
TypeError: Cannot read property 'tls' of undefined
at Object.exports.createMultiplexServer (...\ProjRoot\node_modules\thrift\lib\thrift\s
erver.js:89:14)
at Object.exports.createServer (...\ProjRoot\node_modules\thrift\lib\thrift\server.js:106:18)
at Object.<anonymous> (...\ProjRoot\NodeServer.js:8:21)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:929:3