[THRIFT-2900] Python THttpClient does not reset socket timeout on exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Python - Library
• Assignee: Jens Geyer
• Reporter: Aiden Scandella
• Created: 17/Dec/14 00:34
• Updated: 26/Jan/15 02:26
• Resolved: 05/Jan/15 20:20

Description

https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/py/src/transport/THttpClient.py;h=ea80a1ae875865a297a7b14dad15757e3933284f;hb=HEAD#l106

102 def __withTimeout(f):
103 def _f(*args, **kwargs):
104 orig_timeout = socket.getdefaulttimeout()
105 socket.setdefaulttimeout(args[0].__timeout)
106 result = f(*args, **kwargs)
107 socket.setdefaulttimeout(orig_timeout)
108 return result
109 return _f

if f raises, the default timeout is not reset. Should be wrapped in a try/finally