[THRIFT-2873] TPipe and TPipeServer don't compile on Windows with UNICODE enabled

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Labels: unicode windows

Environment

Visual Studio 2013

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Pascal Bach
• Created: 03/Dec/14 10:48
• Updated: 26/Jan/15 02:26
• Resolved: 06/Dec/14 15:31

Description

When compiling the Thrift C++ library with UNICODE enabled TPipe and TPipeServer won't compile as the are using LPSTR which only works with Multi byte charactersets.

The appended patch uses LPTSTR instead of LPSTR which is set based on the UNICODE flag by Visual Studio.
It also does some casts from raw const char * to LPCSTR.