[THRIFT-2872] ThreadManager deadlock for task expiration

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Qiao Mu
• Created: 03/Dec/14 03:24
• Updated: 21/Jul/15 02:21
• Resolved: 03/Jul/15 18:47

Description

I have a TNonblockingServer running with 1 worker thread and 10 IO thread.

If there was a big task that just finished, all pending tasks might be expired. In such case, all IO threads are waiting for maxMonitor_, but the worker won't notify. It will remove all the tasks(all of them are expired) first. And then the notify code won't be executed because tasks are empty. Deadlock occurs.

The patch move the if-notify statement out so it will notify even if all tasks are removed for expiration.