Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2851

Remove strange public Peek() from Go transports

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9.2
    • 0.9.3
    • Go - Library
    • None
    • Patch Available

    Description

      I've been seeing this public Peek() function in the GO library for a while, but
      still cannot figure out any sense to it.

      If there are useless, we can remove them right?

      This PR removes the public Peek() from the implemented transports.
      All tests still pass.

      PR: https://github.com/apache/thrift/pull/283

      Attachments

        Activity

          People

            jensg Jens Geyer
            cvlchinet Chi Vinh Le
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: