Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2827

Thrift 0.9.2 fails to compile on Yosemite due to tr1/functional include in ProcessorTest.cpp

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.9.3
    • Component/s: C++ - Library, Test Suite
    • Labels:
      None
    • Environment:

      OS X Yosemite

      Description

      I am trying to update the homebrew recipe for OS X to build Thrift 0.9.2. The current 0.9.1 formula includes many patches in order to get it building.

      Currently the only error left is in compiling processor/ProcessorTest.cpp

      processor/ProcessorTest.cpp:26:10: fatal error: 'tr1/functional' file not found
      #include <tr1/functional>
      ^
      1 error generated.
      make[4]: *** [processor/ProcessorTest.o] Error 1
      make[3]: *** [all-recursive] Error 1
      make[2]: *** [all-recursive] Error 1
      make[1]: *** [all-recursive] Error 1
      make: *** [all] Error 2

      This file seems to have been added in THRIFT-1336 and is the only file I see that still tries to include tr1/functional directly. Ignoring this error produces a workable thrift 0.9.2 package without any custom patches.

      Homebrew issue I'm working on is here: https://github.com/Homebrew/homebrew/issues/34194

      Is this as simple as swapping out the include for thrift/cxxfunctional.h ? Or am I missing something.

        Attachments

          Activity

            People

            • Assignee:
              hcorg Konrad Grochowski
              Reporter:
              aiden Aiden Scandella
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: