[THRIFT-2810] Do not leave the underlying ServerSocket open if construction of TServerSocket fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.3
• Component/s: Java - Library
• Patch Info: Patch Available
• Assignee: Guido de Caso
• Reporter: Guido de Caso
• Created: 10/Nov/14 17:41
• Updated: 26/Jan/15 02:26
• Resolved: 10/Nov/14 18:20

Description

If construction of a TServerSocket fails the underlying ServerSocket object may already have been initialized. Since the reference is nullified, we loose the opportunity to properly close it. This fix addresses the issue by always cleaning up after failures during construction.

Additionally, the failure message is added to the exception for improved visibility of what went wrong