[THRIFT-2804] Pull an interface out of TBaseAsyncProcessor

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: Java - Library
• Patch Info: Patch Available
• Assignee: Michael Donaghy
• Reporter: Michael Donaghy
• Created: 07/Nov/14 16:17
• Updated: 26/Jan/15 02:26
• Resolved: 07/Nov/14 17:58

Description

TNonblockingServer and friends are currently quite tightly coupled to TBaseAsyncProcessor, using an instanceof check to determine whether to use the async-processor or sync-processor code path. This makes it impossible to write a "custom" async processor, as any processor which is not a TBaseAsyncProcessor will use the sync code path (which behaves incorrectly with async processors).

The idea is to separate out an interface, TAsyncProcessor. Custom async processors can then implement this interface and the server will take the async code path when used with such a processor.

Code at https://github.com/apache/thrift/pull/253