Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2804

Pull an interface out of TBaseAsyncProcessor

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.3
    • Component/s: Java - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      TNonblockingServer and friends are currently quite tightly coupled to TBaseAsyncProcessor, using an instanceof check to determine whether to use the async-processor or sync-processor code path. This makes it impossible to write a "custom" async processor, as any processor which is not a TBaseAsyncProcessor will use the sync code path (which behaves incorrectly with async processors).

      The idea is to separate out an interface, TAsyncProcessor. Custom async processors can then implement this interface and the server will take the async code path when used with such a processor.

      Code at https://github.com/apache/thrift/pull/253

        Attachments

          Activity

            People

            • Assignee:
              lmmworkv Michael Donaghy
              Reporter:
              lmmworkv Michael Donaghy
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: