Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2804

Pull an interface out of TBaseAsyncProcessor

VotersStop watchingWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • Java - Library
    • None
    • Patch Available

    Description

      TNonblockingServer and friends are currently quite tightly coupled to TBaseAsyncProcessor, using an instanceof check to determine whether to use the async-processor or sync-processor code path. This makes it impossible to write a "custom" async processor, as any processor which is not a TBaseAsyncProcessor will use the sync code path (which behaves incorrectly with async processors).

      The idea is to separate out an interface, TAsyncProcessor. Custom async processors can then implement this interface and the server will take the async code path when used with such a processor.

      Code at https://github.com/apache/thrift/pull/253

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            lmmworkv Michael Donaghy
            lmmworkv Michael Donaghy
            Votes:
            0 Vote for this issue
            Watchers:
            4 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment