[THRIFT-2798] Thrift does not compile on Windows with TARGET_WIN_XP=0

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.9.1, 0.9.2
• Component/s: C++ - Library
• Assignee: Unassigned
• Reporter: Alex Merry
• Created: 06/Nov/14 12:15
• Updated: 15/Jan/19 14:37

Description

To compile with Visual Studio 2013 after defining TARGET_WIN_XP=0 (and HAVE_STDINT_H=1), I have to do the following:

1. Remove BoostThreadFactory.cpp and BoostThreadFactory.h from concurrency
2. Add
   #ifndef WINVER
   # define WINVER 0x0601
   #endif
   after
   #ifndef _WIN32_WINNT
   # define _WIN32_WINNT 0x0601
   #endif
   in windows/config.h
3. Remove #include <thrift/transport/PlatformSocket.h> from Thrift.h (or move it to after #include <thrift/thrift-config.h>), since it depends on the WINVER definition from windows/config.h.

I'm not sure what the best fix for the boost thread factory thing is (maybe #ifdef the file contents based on USE_BOOST_THREAD?), but I think the other code changes should go in.

It may also be worth having
#if _MSC_VER >= 1800
# define HAVE_STDINT_H
#endif
in windows/config.h.

Issue Links

• relates to: THRIFT-4720 Drop support for C++03/C++98 and begin refactoring