[THRIFT-2789] TNonblockingServer leaks socket FD's under load

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Sergey
• Created: 18/Oct/14 01:25
• Updated: 22/Mar/17 18:52
• Resolved: 04/Dec/14 20:53

Description

I checked 0.9.2 and 1.0, but code didn't seem to change in 1.2 either.

Problem is that network threads and worker threads use non-blocking socket (pipe) to communicate. Under heavy load writes to that pipe might fail with EAGAIN. While 'notifyIOThread' method carefully checks for the error and communicates the result via return value, not all callers check result of 'notify'.

Generally it's hard to tell what appropriate handling of such a failure would be, but it's clear sockets shouldn't leak. Please use attached patch for the reference, but I do not insist what I did there is the best way to fix the problem.

Issue Links

• breaks: THRIFT-4129 C++ TNonblockingServer fd leak when failing to dispatch new connections