Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2745

C++ - Unit-test compilation on Windows fixes

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.2
    • C++ - Library, Test Suite
    • None
    • Windows 7 (64bit)
      Microsoft Visual Studio 2012

    • Patch Available

    Description

      Issue 1:
      thrift\lib\cpp\test\concurrency\ThreadFactoryTests.h uses <unistd.h> for usleep().

      Replaced usleep() with THRIFT_SLEEP_USEC() and removed inclusion of unistd.h

      Issue 2:
      static const double ERROR;
      macro ERROR already defined in wingdi.h

      Replaced with TEST_ERROR, but perhaps it is better to find it more better name.

      PR: https://github.com/apache/thrift/pull/207

      Attachments

        Activity

          People

            snikulov Sergei Nikulov
            snikulov Sergei Nikulov
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: