Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2658

Rebuilds of the python compiler do not invalidate generated sources for tests

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Python - Compiler
    • Labels:
      None

      Description

      Rebuilds of the python code compiler do not cause generated source in the test directories to be rebuilt.

      This can cause false positive and negative test results while working on the compiler.

      To reproduce:

        git checkout master 
        make check  # passes
        git apply patch.patch
        make check # passes :( 
        rm -rf test/py/gen-py*
        make check # fails 
      

      Workaround: manually delete gen.py* before each test run.

        Attachments

        1. patch.patch
          0.6 kB
          James Broadhead

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jamesbroadhead James Broadhead
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: