[THRIFT-2647] compiler-hs: don't decapitalize field names, do decapitalize argument bindings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: Haskell - Compiler
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: John Chee
• Created: 05/Aug/14 00:44
• Updated: 21/Jul/15 02:53
• Resolved: 21/Jul/15 02:53

Description

By modifying the haskell compiler slightly we can enable the NameConflictTest.

make check in test/hs succeeds with:

sh run-test.sh NameConflictTest
Running test...

../../lib/hs/src/Thrift/Types.hs:27:10: Warning:
    Orphan instance:
      instance (Hashable k, Hashable v) => Hashable (Map.HashMap k v)

../../lib/hs/src/Thrift/Types.hs:30:10: Warning:
    Orphan instance: instance Hashable a => Hashable (Set.HashSet a)

../../lib/hs/src/Thrift/Types.hs:33:10: Warning:
    Orphan instance: instance Hashable a => Hashable (Vector.Vector a)

../../test/hs/NameConflictTest_Main.hs:5:1: Warning:
    The import of ‘NameConflictTest_Consts’ is redundant
      except perhaps to import instances from ‘NameConflictTest_Consts’
    To import instances alone, use: import NameConflictTest_Consts()

../../test/hs/NameConflictTest_Main.hs:7:1: Warning:
    The import of ‘Qualified’ is redundant
      except perhaps to import instances from ‘Qualified’
    To import instances alone, use: import Qualified()

...

Values:
[JUST,TRUE,FALSE]
[LEFT,RIGHT]
Problem_ {f_Problem__problem = Just True, f_Problem__Problem = Just False}

Successful travis run: https://travis-ci.org/cheecheeo/thrift/jobs/31667026

cc: roger.meier

Issue Links

• is related to: THRIFT-2764 Haskell does not build/test when using the Trusty Vagrantfile