[THRIFT-2642] Recursive structs don't work in python

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.11.0
• Component/s: Python - Compiler, Python - Library
• Assignee: Eric Conner
• Reporter: Igor Kostenko
• Created: 30/Jul/14 10:58
• Updated: 24/Aug/18 10:08
• Resolved: 06/Jul/17 21:00

Description

Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because generated code trying to use objects which not constructed yet.

Struct:

struct Recursive {
1: list<Recursive> Children
}

Python code:

class Recursive:
  thrift_spec = (
    None, # 0
    (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, Recursive.thrift_spec)), None, ), # 1
  )

Error message:

Traceback (most recent call last):
  File "ttypes.py", line 20, in <module>
    class Recursive:
  File "ttypes.py", line 28, in Recursive
    (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, Recursive.thrift_spec)), None, ), # 1
NameError: name 'Recursive' is not defined

Issue Links

• breaks: THRIFT-4623 Python compiler generates inoperable definitions for default-valued classes in same thrift file
• causes: THRIFT-4510 Regression in 0.11: Arrays with default values in python
• links to: GitHub Pull Request #1293