[THRIFT-2595] Node.js: Fix global leaks and copy-paste errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: Node.js - Library
• Patch Info: Patch Available
• Assignee: Wade Simmons
• Reporter: Wade Simmons
• Created: 01/Jul/14 20:49
• Updated: 06/Jul/14 04:00
• Resolved: 04/Jul/14 19:29

Description

• TCompactProtocol.prototype.writeBool not referencing `booleanField_`
  on `this` correctly. Also using `NULL` instead of `null`.

• TCompactProtocol.prototype.writeVarint64 had a typo for TProtocolException

• TCompactProtocol.prototype.readMapBegin had a typo between `kvtype` and
  `kvType`

• createMultiplexServer leaked a global var `processStatus`

• TFramedTransport had a line that was accidently copy pasted, leading
  to a global leak of `frameLeft`. (I created the patch the introduced
  this copy paste error in Thrift-1353, so I can confirm it was
  a mistake).

• createWebServer tried to check a non-existent var `route` and leaked
  a global `result`