Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2595

Node.js: Fix global leaks and copy-paste errors

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.1
    • Fix Version/s: 0.9.2
    • Component/s: Node.js - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      • TCompactProtocol.prototype.writeBool not referencing `booleanField_`
        on `this` correctly. Also using `NULL` instead of `null`.
      • TCompactProtocol.prototype.writeVarint64 had a typo for TProtocolException
      • TCompactProtocol.prototype.readMapBegin had a typo between `kvtype` and
        `kvType`
      • createMultiplexServer leaked a global var `processStatus`
      • TFramedTransport had a line that was accidently copy pasted, leading
        to a global leak of `frameLeft`. (I created the patch the introduced
        this copy paste error in Thrift-1353, so I can confirm it was
        a mistake).
      • createWebServer tried to check a non-existent var `route` and leaked
        a global `result`

        Attachments

          Activity

            People

            • Assignee:
              wadey Wade Simmons
              Reporter:
              wadey Wade Simmons
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: