[THRIFT-2594] JS Compiler: Single quotes are not being escaped in constants.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: JavaScript - Compiler

Environment

Windows 7

• Assignee: Roger Meier
• Reporter: Thomas Lazar
• Created: 30/Jun/14 08:42
• Updated: 06/Jul/14 04:00
• Resolved: 04/Jul/14 19:43

Description

If you define a constant containing single quotes in the thrift IDL the resulting JS constants are not properly escaped.

Example:

test.thrift

const string test = "blah ' blub '' blahblahblubberblub''''''''"

gets compiled into

test_types.js

test = 'blah ' blub '' blahblahblubberblub''''''''';

instead it should result in

test_types.js - new

test = 'blah \' blub \'\' blahblahblubberblub\'\'\'\'\'\'\'\'';