[THRIFT-2466] Improper error handling for SSL/TLS connections that don't complete a handshake

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: Python - Library
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Benoit Sigoure
• Created: 14/Apr/14 02:19
• Updated: 06/Jul/14 04:00
• Resolved: 21/Apr/14 19:21

Description

The code in TSSLServerSocket.accept() silently drops all SSLError and returns None instead, but none of the TServer implementations handle this case properly, which cause them to pass None around a bunch, which eventually cause weird AttributeError exceptions.

This bug is easy to reproduce: just open a socket to a Python Thrift server that uses SSL/TLS and close the connection right away.

Issue Links

• blocks: THRIFT-2463 test/py/RunClientServer.py fails sometimes