Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2466

Improper error handling for SSL/TLS connections that don't complete a handshake

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.1
    • Fix Version/s: 0.9.2
    • Component/s: Python - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The code in TSSLServerSocket.accept() silently drops all SSLError and returns None instead, but none of the TServer implementations handle this case properly, which cause them to pass None around a bunch, which eventually cause weird AttributeError exceptions.

      This bug is easy to reproduce: just open a socket to a Python Thrift server that uses SSL/TLS and close the connection right away.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                roger Roger Meier
                Reporter:
                tsuna Benoit Sigoure
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: