Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2443

Node fails cross lang tests

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.9.2
    • Component/s: Node.js - Library
    • Labels:
      None
    • Environment:

      tests

    • Patch Info:
      Patch Available

      Description

      As reported by Chamila:

      The Node.js test_driver.js fails on cross platform tests due to mismatches in leaf elements of the testInsanity() method return value. Node supplying nulls and C++ supplying an empty map and empty list.

      Taking the C++ form as the defacto correct wire implementation, this patch updates Node.js to expect/return empty objects rather than null.

      This patch also adds the ability to test i64 values when within the limits of a JavaScript number.

      Note that Node.js multiplex tests still fail per THRIFT-2405

        Attachments

          Activity

            People

            • Assignee:
              codesf Randy Abernethy
              Reporter:
              codesf Randy Abernethy
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: