[THRIFT-2418] Go handler function panics on internal error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.2
• Component/s: Go - Compiler

Environment

All

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Frank Schroeder
• Created: 20/Mar/14 18:47
• Updated: 01/Apr/14 20:02
• Resolved: 20/Mar/14 21:10

Description

The Go compiler is using the wrong err variable when handling an internal error in a handler method. Tested on fd62df75fa17d5c2af12302de6cee78ad7405692.

The relevant generated code looks like this:

var err2 error
if result.Success, err2 = p.handler.RemoveBatchBySource(args.SourceId, args.SourceSystem, args.SourceType, args.UserId); err2 != nil {
	x := thrift.NewTApplicationException(thrift.INTERNAL_ERROR, "Internal error processing removeBatchBySource: "+err.Error())
	oprot.WriteMessageBegin("removeBatchBySource", thrift.EXCEPTION, seqId)
	x.Write(oprot)
	oprot.WriteMessageEnd()
	oprot.Flush()
	return false, err2
}

The error in the TApplicationException should be err2.Error() and not err.Error(). Since err is nil at that point the server panics.

The patch for the Go compiler is a simple one line fix is attached.