Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
0.9.2
-
None
-
All
-
Patch Available
Description
The Go compiler is using the wrong err variable when handling an internal error in a handler method. Tested on fd62df75fa17d5c2af12302de6cee78ad7405692.
The relevant generated code looks like this:
var err2 error if result.Success, err2 = p.handler.RemoveBatchBySource(args.SourceId, args.SourceSystem, args.SourceType, args.UserId); err2 != nil { x := thrift.NewTApplicationException(thrift.INTERNAL_ERROR, "Internal error processing removeBatchBySource: "+err.Error()) oprot.WriteMessageBegin("removeBatchBySource", thrift.EXCEPTION, seqId) x.Write(oprot) oprot.WriteMessageEnd() oprot.Flush() return false, err2 }
The error in the TApplicationException should be err2.Error() and not err.Error(). Since err is nil at that point the server panics.
The patch for the Go compiler is a simple one line fix is attached.