[THRIFT-2333] RPMBUILD: Abort build if user did not disable ruby but ruby build will fail later on

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Build Process

Environment

RPM environments

• Assignee: Nevo Hed
• Reporter: Nevo Hed
• Created: 25/Jan/14 21:13
• Updated: 16/Oct/19 22:27
• Resolved: 20/Dec/18 03:13

Description

As can be seen in this email message to the users list it is possible for some pre-required packages to be missing, but the traditional method for validating their existence in specfile using "BuildRequires" won't work for items that are not commonly available as RPMS.

http://mail-archives.apache.org/mod_mbox/thrift-user/201401.mbox/%3CCACeqxwQrLr7ghoBmbabQpu7z_u0FHjh+vbYXQKwP8=[e-mail]%3E

I think that in this user's case the missing bit is the bundler gem, which I have a locally built RPM for, but I have to assume that most folks do not and it is not commonly available in most repos (not that I saw as a Centos6.4 user anyway)

The patch I am attaching just checks if ruby subpackage was not disabled at the (at the buildrpm level) and if the results of ./configure have determined that "make install" won't build the gem (and so the rpm build of the rubygem-thrift subpackage is bound to fail) abort the build with a clear message

An alternative solution MAY be to just dynamically skip that package when it is detected that ./configure excluded ruby (I don't know off hand how to do that)

Issue Links

• relates to: THRIFT-4097 Support for Fedora / CentOS / RHEL distribution - packaging and CI builds