Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2333

RPMBUILD: Abort build if user did not disable ruby but ruby build will fail later on

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Build Process
    • Labels:
      None
    • Environment:

      RPM environments

      Description

      As can be seen in this email message to the users list it is possible for some pre-required packages to be missing, but the traditional method for validating their existence in specfile using "BuildRequires" won't work for items that are not commonly available as RPMS.

      http://mail-archives.apache.org/mod_mbox/thrift-user/201401.mbox/%3CCACeqxwQrLr7ghoBmbabQpu7z_u0FHjh+vbYXQKwP8=ibR4bHKQ@mail.gmail.com%3E

      I think that in this user's case the missing bit is the bundler gem, which I have a locally built RPM for, but I have to assume that most folks do not and it is not commonly available in most repos (not that I saw as a Centos6.4 user anyway)

      The patch I am attaching just checks if ruby subpackage was not disabled at the (at the buildrpm level) and if the results of ./configure have determined that "make install" won't build the gem (and so the rpm build of the rubygem-thrift subpackage is bound to fail) abort the build with a clear message

      An alternative solution MAY be to just dynamically skip that package when it is detected that ./configure excluded ruby (I don't know off hand how to do that)

        Attachments

        1. THRIFT-2333.patch
          0.8 kB
          Nevo Hed

          Issue Links

            Activity

              People

              • Assignee:
                nhed Nevo Hed
                Reporter:
                nhed Nevo Hed
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: